[Dune] [Dune-Commit] dune-common r6141 - trunk/dune/common

[Christian Engwer]

On Thu, Sep 09, 2010 at 02:11:24PM +0200, Oliver Sander wrote:
> Hi Christian!
> >I'm somewhat surprised... why did you deprecate the heaer. It was
> >explicitly introduced, to make the code portable, even if the config.h
> >is missing.
> I was assuming that config.h would always be there.
> And why would I need the file, then?  If you want to
> handle situations without config.h then I guess we
> need it.  But this was never documented.

This issue was discussed in FS#295 adn there were a few further
(later) bug reports about certain problem when building dune without
config.h. Also parsing a header without config.h is one of the tests
run during make headercheck.

Christian

> 
> best,
> Oliver
> 
> >The feature was always in config.h, but there were certain problems
> >using dune without config.h if you didn't have this file.
> >
> >I still believe, we can not remove the header.
> >
> >Christian
> >
> >
> >On Thu, Sep 09, 2010 at 10:04:11AM +0200, sander at dune-project.org wrote:
> >>Author: sander
> >>Date: 2010-09-09 10:04:10 +0200 (Thu, 09 Sep 2010)
> >>New Revision: 6141
> >>
> >>Modified:
> >>    trunk/dune/common/deprecated.hh
> >>Log:
> >>Mark this file as deprecated.  Its functionality is actually fully
> >>provided by config.h.
> >>
> >>
> >>Modified: trunk/dune/common/deprecated.hh
> >>===================================================================
> >>--- trunk/dune/common/deprecated.hh	2010-09-09 05:19:57 UTC (rev 6140)
> >>+++ trunk/dune/common/deprecated.hh	2010-09-09 08:04:10 UTC (rev 6141)
> >>@@ -1,6 +1,8 @@
> >>  #ifndef DUNE_DEPRECATED_HH
> >>  #define DUNE_DEPRECATED_HH
> >>
> >>+#warning This file has been deprecated in dune-common 2.1.  There is no replacement, you may simply omit it.
> >>+
> >>  //! @addtogroup Common
> >>  //! @{
> >>  #if defined(DOXYGEN) or not defined(DUNE_DEPRECATED)
> >>
> >>
> >>_______________________________________________
> >>Dune-Commit mailing list
> >>Dune-Commit at dune-project.org
> >>http://lists.dune-project.org/mailman/listinfo/dune-commit
> >>
> >_______________________________________________
> >Dune mailing list
> >Dune at dune-project.org
> >http://lists.dune-project.org/mailman/listinfo/dune
> 
>