[Dune] [#987] build system: do not force all modules to place their headers in $DUNE_MODULE_ROOT/dune/

Dune flyspray at dune-project.org
Tue Dec 6 13:24:21 CET 2011


The following task has a new comment added:

FS#987 - build system: do not force all modules to place their headers in $DUNE_MODULE_ROOT/dune/
User who did this - Andreas Lauser (andlaus)

> No, this would just be a strange hack to use the current DUNE_CHECK_MODULES test. I also think a module should keep all its headers below the dune directory.

I think the strange hack is that the current version of DUNE_CHECK_MODULES adds the dune/ prefix to the path it was pointed to. I guess that this is an artifact of the time where all modules had their headers directly in $DUNE_MODULE_ROOT/$MODULE_NAME and the dune subdirectory was just a symbolic to $DUNE_MODULE_ROOT.

> No no no! You should never ever ovwrite existing m4 macros. This is the first step to hell and all kinds of problems (see out difficulties with the Fortran test). Why don't you just write your modified test? You should always give it a different name.

I did not overwrite DUNE_CHECK_MODULES. I used DUMUX_CHECK_MODULES as new name for the modfied version

> Why don't you want to provide your headers under the dune/ path?

because IMHO #include <dune/dumux/common/spline.hh> looks awkward.

More information can be found at the following URL:

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

More information about the Dune mailing list