[Dune] [Dune-Commit] dune-grid r7502 - trunk/dune/grid/genericgeometry/test

[Martin Nolte]

I agree. Just go ahead.

The current solution was just the fasted fix to resolve the 'make check' issue
that still stops the 2.1 release.

As far as I remember it was Jö who added this test. Maybe he can comment...

Best,

Martin

On 03/04/2011 05:47 PM, Oliver Sander wrote:
> Hi Martin!
>> * mark testbasicgeometry as expected to fail until semantics of method volume
>>    are clarified.
>>    
> I don't think that is a good idea.  Testbasicgeometry tests a lot of things.
> What if somebody breaks something in BasicGeometry?  The test will
> not tell us because we said that we expect it to fail anyways.
> 
> I think the proper way to handle the volume()-issue in the short term
> is to not test that method in testbasicgeometry.cc.
> 
> Best,
> Oliver
> 
>>
>> Modified: trunk/dune/grid/genericgeometry/test/Makefile.am
>> ===================================================================
>> --- trunk/dune/grid/genericgeometry/test/Makefile.am    2011-03-03 17:22:38
>> UTC (rev 7501)
>> +++ trunk/dune/grid/genericgeometry/test/Makefile.am    2011-03-04 15:00:54
>> UTC (rev 7502)
>> @@ -10,7 +10,8 @@
>>   check_HEADERS = testgeo.hh
>>
>>   check_PROGRAMS = testbasicgeometry testsubtopologies testmapping testgeo
>> testmatrix
>> -TESTS = $(check_PROGRAMS)
>> +TESTS = testbasicgeometry testsubtopologies testmapping testgeo
>> +XFAIL_TESTS = testbasicgeometry
>>
>>   AM_CPPFLAGS = @AM_CPPFLAGS@ $(ALL_PKG_CPPFLAGS)
>>   AM_LDFLAGS = @AM_LDFLAGS@ $(ALL_PKG_LDFLAGS)
>>
>>
>> _______________________________________________
>> Dune-Commit mailing list
>> Dune-Commit at dune-project.org
>> http://lists.dune-project.org/mailman/listinfo/dune-commit
>>    
> 
> 
> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune

-- 
Martin Nolte <nolte at mathematik.uni-freiburg.de>

Universität Freiburg                                   phone: +49-761-203-5642
Abteilung für angewandte Mathematik                    fax:   +49-761-203-5632
Hermann-Herder-Straße 10
79104 Freiburg, Germany