[Dune] [#925] Consistent Coding Style in the Core Modules

[Dune]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#925 - Consistent Coding Style in the Core Modules
User who did this - Oliver Sander (sander)

----------
Hi Andreas!
Thank you very much for the patch!  I very much appreciate you not just complaining but going out and doing something about it.

I agree with you on the value of consistency.  But it is difficult to just go ahead and commit your patch:

- Most of the dune-istl names that use an all_lower_case_and_underscores naming scheme just got picked
  without paying attention to a dune-wide style.  They really should be changed (or declared to be the
  new Dune naming standard.  Then everything else should be changed).  However that would lead to a new
  transition period with lots of deprecation warnings and such.  A fair share of Dune developers may not
  think it is worth the trouble.
- The 'official' naming scheme has the disadvantage of being stl-incompatible.  However one frequently wants
  to write algorithms that can take Dune containers and stl containers.  That's why typedefs such as size_type
  and value_type started to appear.  They are inconsistent, but very useful.

I am not particularly happy with the situation, because I think that you can tell the really great programs
by their internal consistency.  If I was to start again from scratch I'd probably forget about camel case and
use the stl conventions throughout.  However changing that now will be a lot of work.

cheers,
Oliver
----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=925#comment2566

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.