[Dune] [#925] Consistent Coding Style in the Core Modules

Dune flyspray at dune-project.org
Mon May 30 23:44:31 CEST 2011


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#925 - Consistent Coding Style in the Core Modules
User who did this - Andreas Lauser (andlaus)

----------
Hi Oliver,

First of all: thanks for the quick answer. Personally, I think that using CamelCase was a good decision, since IMHO it does looks nicer om the code than the underscores_and_lower_case approach and my impression is that most other c++ projects also use it. (But I am aware that this is pretty much a matter of taste.) Regarding the matter of STL compatibility, I would propose to make an exception for everything that needs to be compatible with STL, (which does basically boil down to "iterator", "const_iterator" and "allocator" typedefs). If it was implemented like that, the documentation should always refer to the CamelCase names IMHO. What I consider quite unfortunate in the current situation, is that most stuff is camel case, but some isn't and that even within individual ISTL classes it is inconsistent, see e.g. the ConstColIterator vs. block_type in BCRSMatrix. People like you and me just get annoyed by this occasionally, but newbies have to consult the documentation which causes
them to loose a lot of time or -- worse -- request to be supported by people like us ;)

just my 2c
Andreas 
----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=925#comment2567

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.




More information about the Dune mailing list