[Dune] [Dune-Commit] dune-grid r7723 - trunk/dune/grid/io/file/vtk

[Jö Fahlke]

Am Wed,  2. Nov 2011, 15:14:28 +0100 schrieb mnolte at dune-project.org:
> Subject: [Dune-Commit] dune-grid r7723 - trunk/dune/grid/io/file/vtk
> 
> Author: mnolte
> Date: 2011-11-02 15:14:27 +0100 (Wed, 02 Nov 2011)
> New Revision: 7723
> 
> Modified:
>    trunk/dune/grid/io/file/vtk/function.hh
>    trunk/dune/grid/io/file/vtk/volumewriter.hh
>    trunk/dune/grid/io/file/vtk/vtkwriter.hh
> Log:
> extract types from the GridView instead of the Grid

Hi Martin!

This is a good idea, although the way you have done it is problematic, because
you have done without possibility for transition.  While you adjusted
P0Function and P1Function, anyone using the VTKWriter or one of it's variants
with a slightly more complicated must also adjust his function.  The way you
have done it pretty much completely breaks PDELab, for instance.  Could you
please provide a transition path, preferably with deprecation?

Thanks,
Jö.

-- 
Jorrit (Jö) Fahlke, Interdisciplinary Center for Scientific Computing,
Heidelberg University, Im Neuenheimer Feld 368, D-69120 Heidelberg
Tel: +49 6221 54 8890 Fax: +49 6221 54 8884

featured product: Debian GNU/Linux - http://www.debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <https://lists.dune-project.org/pipermail/dune/attachments/20111106/88fe827b/attachment.sig>