[Dune] [Dune-Commit] dune-istl r1524 - trunk/m4

[Christian Engwer]

On Sat, Feb 11, 2012 at 11:26:35AM +0100, Jö Fahlke wrote:
> Am Sat, 11. Feb 2012, 09:43:21 +0100 schrieb Christoph Grüninger:
> > In dune-grid occurs Metis only in comments [1] but
> > neither the test is run or required nor is any header
> > included or symbol used with "metis" in it.
> > On the other hand a metis.m4 and a parmetis.m4 can be
> > found in ALUGrid's m4 directory. So I am pretty sure that the
> > test from dune-common was not needed for dune-grid.
> 
> Hmm.  I would expect that ALUGrid's headers (conditionally) include metis.h,
> and ALUGrid's headers are included by dune-grid.  Additionally, I would have
> expected that -lmetis (or similar) must be specified during linking -- at
> least for static libraries when linking without libtool (e.g. debian
> packages).
> 
> But since the test wasn't called by dune-grid before, this is a moot point:
> you didn't break anything that wasn't broken before.

are you sure the test wasn't run implcitly by some other test.

Christoph,
please be cautious with changes to the build-system. It is fragile!

Christian

> Bye,
> Jö.
> 
> -- 
> Jorrit (Jö) Fahlke, Interdisciplinary Center for Scientific Computing,
> Heidelberg University, Im Neuenheimer Feld 368, D-69120 Heidelberg
> Tel: +49 6221 54 8890 Fax: +49 6221 54 8884
> 
> Interpunktion, Orthographie und Grammatik der Email ist frei erfunden.
> Eine Übereinstimmung mit aktuellen oder ehemaligen Regeln wäre rein
> zufällig und ist nicht beabsichtigt.



> _______________________________________________
> Dune mailing list
> Dune at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune