[Dune] [Dune-Commit] dune-common r6877 - trunk/dune/common

[Matthias Wohlmuth]

  I don't like the int-constructor patch either, as sometimes the 
int-->complex<double> casts cause me trouble. That was the main reason 
to implement it stl-like in the original dotproduct patch:

PromotedType result = PromotedType();

My problem was, that I was not aware of further classes like MultiIndex 
which derive from some vectors. So I didn't test MultiIndex. Are we 
sure, that there are no further classes (like MultiIndex) which do not 
initialize to 0?

IMHO, the main advantage of the last patch is, that it restores the 
behavior of the old operator* (befor the dotproduct patches)...

Cheers,
Matthias


Am 07/31/2012 02:48 PM, schrieb Markus Blatt:
> Hi Andreas,
>
> On Tue, Jul 31, 2012 at 12:19:06PM +0000, Dedner, Andreas wrote:
>> Just yesterday I had a look at this and the MultiIndex can be initialized with zero
>> apparently without breaking anything. So I assume that we can change that behavior.
>> I wanted to discuss this with Martin and then commit it but Christian had then already
>> make the change with the int constructor - but I was also wondering about that int constructor...
>> So w.r.t. to MultiIndex the change is probably not required....
>>
> Sounds great. So once you sorted this out with Martin and changed the
> MultiIndex behaviour I would propose to revert Christians patches to
> common and istl. (Your other option with a Zero class would be fine,
> too. But the less additional code needed the better.)
>
>
> Cheers,
>
> Markus
>


-- 
*****************************************************************
***************  Dr.-Ing Dipl.-Math. Matthias Wohlmuth
************
**********  Department of Mathematics (M2)
********  Technische Universität München (TU Munich)
******  Boltzmannstr. 3, 85748 Garching, Germany
****
**  http://www-m2.ma.tum.de/bin/view/Allgemeines/MatthiasWohlmuth
****  matthias.wohlmuth at ma.tum.de
******  Phone: +49 89 / 289 18441
********  Fax: +49 89 / 289 18435
**********  Office: 03.10.036
*****************************************************************