[Dune] Removal of deprecated VTKOptions

[Jö Fahlke]

Am Thu, 14. Jun 2012, 20:30:31 +0200 schrieb Robert Kloefkorn:
> Christoph did the correct thing by removing the deprecated VTKOptions
> class after the release and I hereby thank him for all the work that he
> has been doing lately to improve the code quality of DUNE. There is
> absolutely no need to have an additional announcement for removing
> deprecated classes, big change or not. Next time we'll have to fill a
> form or what? This is exactly the right way to get people less and less
> interested in investing time into something like DUNE.
> 
> From the people complaining nobody mentioned so far that the
> DUNE_DEPRECATED tag for the VTKOptions class did not work at all. The
> deprecation was there for a long time an nobody noticed. So if somebody
> should be blamed then the one you implemented this deprecation tag
> without checking that it works correctly.

The one would be me, except that I did try to get it working, as you can see
from the comments in the code.  I don't remember in which way the many
possibilites I tried failed exactly, but here is a list of the most likely
candidates:

 * The tried position of DUNE_DEPRECATED inside the constant definition failed
   to have any effect at all.

 * The tried position of DUNE_DEPRECATED inside the constant definition
   resulted in an immediate compiler error.

 * The tried position of DUNE_DEPRECATED inside the constant definition worked
   correctly on one compiler, but resulted in a compiler error on another of
   the many compiler (versions) supported by Dune.

I apologise however for not announcing this in recent_changes.

Oh, and for what it's worth, I do think that Christoph did the right thing
when removing VTKOptions, given the information he had at hand.  Yes, a
seperate announcement would have been nice.  But this really didn't look like
a biggie before going through with it, and you can't do a seperate
announcement a week before every simple change you plan.

Still, now that we are wiser, maybe it is a good idea to revert and postpone
the removal?  (But only if someone has a way to make the deprecation work
properly...)

Regards,
Jö.

-- 
Jorrit (Jö) Fahlke, Interdisciplinary Center for Scientific Computing,
Heidelberg University, Im Neuenheimer Feld 368, D-69120 Heidelberg
Tel: +49 6221 54 8890 Fax: +49 6221 54 8884

In the beginning the Universe was created.  This has made a lot of
people very angry and been widely regarded as a bad move.
-- Douglas Adams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <https://lists.dune-project.org/pipermail/dune/attachments/20120615/74c40287/attachment.sig>