[Dune] [Dune-Commit] dune-grid r8200 - trunk/dune/grid/test

Jö Fahlke jorrit at jorrit.de
Thu May 31 15:47:13 CEST 2012


Am Thu, 31. May 2012, 13:56:29 +0200 schrieb Christoph Grüninger:
> your proposal sounds good. In my patch I followed Oliver's
> suggestions, see [1].
> So, what should I change? Include "#define NDEBUG 0" in every test?
> Or pass it to every test using the Makefile? Or just make sure that
> I'll run the tests only without -DNDEBUG? Should I remove the
> #ifndefs I added?

IMO replace assert() by something that doesn't depend on NDEBUG.  With "#undef
NDEBUG" you also forcibly enable assert() in other headers, even though the
user may have specified -DNDEBUG, which would eb a bit surprising.

Bye,
Jö.

-- 
Jorrit (Jö) Fahlke, Interdisciplinary Center for Scientific Computing,
Heidelberg University, Im Neuenheimer Feld 368, D-69120 Heidelberg
Tel: +49 6221 54 8890 Fax: +49 6221 54 8884

Das Erststudium soll bis zum berufsqualifizierenden Abschluss
gebührenfrei bleiben, also bis zur Erlangung der Taxi-Lizenz.
-- Akrützel, Ausgabe vom 16.5.2002 (www.akruetzel.de)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <https://lists.dune-project.org/pipermail/dune/attachments/20120531/88e4aec3/attachment.pgp>


More information about the Dune mailing list