[Dune] UG grid problem: ID overflow DDD_HdrConstructor

Oliver Sander sander at igpm.rwth-aachen.de
Fri Nov 30 23:23:03 CET 2012


Am 30.11.2012 23:06, schrieb Christian Engwer:
> Hi Eike, hi Oli,
>
>> Do you think the change I made makes sense and doesn't break
>> anything else? If that is the case, what's the best way of setting
>> up a patch? To be on the safe side, maybe something like this:
>>
>> #if (DDD_MAX_PROCBITS_IN_GID<  16)
>>    typedef unsigned short   DDD_PROC;
>> #else
>>    typedef unsigned int   DDD_PROC;
>> #endif // (DDD_MAX_PROCBITS_IN_GID<  16)
> I think the best way to generally change the type of
> DDD_PROC. Sure... we might waste some memory, but there are too few UG
> users to manage a lot of code paths. Oli and me just discussed a
> similar question regarding the DDD id type and decided to change the
> default behaviour of UG, so that all people use the new code and we
> only have to maintain one code path.
I agree.  Let's just make the type unsigned int for everybody.

And many thanks for the debugging!

Oliver
> Christian





More information about the Dune mailing list