[Dune-devel] Broken compatibility for GenericReferenceElement*

[Oliver Sander]

Am 28.08.2013 18:04, schrieb Markus Blatt:
> On Wed, Aug 28, 2013 at 05:21:27PM +0200, Oliver Sander wrote:
>> Am 28.08.2013 17:14, schrieb Christoph Grüninger:
>> I was half-expecting something like this.  But then: that ominous inclusion was not documented,
>> and all module tests still passed after my patch.  Can you please explain the mechanism?
>> Why does referenceelements.hh have to include genericreferenceelements.hh, if nothing from the
>> latter file is used?
>>
>
> Not on my test system, see
> https://dune-project.org/flyspray/index.php?do=details&task_id=1345. But
> that might as well be unrelated.
>

Hi Markus,

it might as well be related.  Sorry for screwing up your code.

However, I do not feel very guilty.  IMO when changing something
in dune-geometry it is only my duty to make sure that the tests
in dune-geometry still work.  Everything else, like e.g. testing
dune-grid, is bonus.  If testing only dune-geometry is not enough
then we need more tests there.

This may sound harsh, but otherwise, we would we stop?  Should it
test for failures in dune-fem or even application-modules-using-
dune-fem, just to be sure?  That's a lot of work.

Best,
Oliver


> Cheers,
>
> Markus
>>
>>>
>>> Sure, the deprecation warning did not work for the classes in the header, but now some programs do not compile at all. Let's try Bernd's advice and deprecate the constructor instead of the whole file.
>>> Can I first revert your two latest commits?
>>
>> Compromise: you leave the #warning in and only revert the other commit?
>>
>