[Dune-devel] [Dune] [Dune-Bugs] dune-common | [dunecontrol] Check less often the version for module dependencies (#28)

Christoph Grüninger christoph.grueninger at iws.uni-stuttgart.de
Tue Jan 19 22:53:30 CET 2016


Hi Christian,

> I don't consider it good style to merge without answering to 
> critical comments.

And I second that.

> I suggested an improvement to help maintaining a bit more
> readability of a code, which is already in it's current 
> state delicate.

Please have a look at commit 72f8b
https://gitlab.dune-project.org/core/dune-common/commit/72f8bfaeb506b397e3e35bf1de723f0a89682518
where I just did as you told me. I waited for a week and
did not hear any objections. Thus I merged the change.
If my changes did not address your concerns, I am happy to
discuss them and improve my changes.

Bye
Christoph

-- 
Je n'ai rien contre les étrangers, quelques uns de mes 
meilleurs amis
sont des étrangers. Mais ces étrangers là ne sont pas de chez 
nous!
[Agecanonix, Astérix - Le cadeau de César]




More information about the Dune-devel mailing list