[Dune-devel] [Dune] [Dune-Bugs] dune-common | [dunecontrol] Check less often the version for module dependencies (#28)
Christian Engwer
christian.engwer at uni-muenster.de
Tue Jan 19 22:57:25 CET 2016
On Tue, Jan 19, 2016 at 10:53:30PM +0100, Christoph Grüninger wrote:
> Hi Christian,
>
> >I don't consider it good style to merge without answering to critical
> >comments.
>
> And I second that.
>
> >I suggested an improvement to help maintaining a bit more
> >readability of a code, which is already in it's current state delicate.
>
> Please have a look at commit 72f8b
> https://gitlab.dune-project.org/core/dune-common/commit/72f8bfaeb506b397e3e35bf1de723f0a89682518
Ah OK! The sorry for the noise. As you never replied to my suggestion
and the commit messages aren't sent anymore I missed this change.
Thanks for this cleanup. That's exactly what I had in mind :-)
Good night
Christian
> where I just did as you told me. I waited for a week and
> did not hear any objections. Thus I merged the change.
> If my changes did not address your concerns, I am happy to
> discuss them and improve my changes.
>
> Bye
> Christoph
>
> --
> Je n'ai rien contre les étrangers, quelques uns de mes meilleurs amis
> sont des étrangers. Mais ces étrangers là ne sont pas de chez nous!
> [Agecanonix, Astérix - Le cadeau de César]
>
> _______________________________________________
> Dune-devel mailing list
> Dune-devel at dune-project.org
> http://lists.dune-project.org/mailman/listinfo/dune-devel
--
Prof. Dr. Christian Engwer
Institut für Numerische und Angewandte Mathematik
Fachbereich Mathematik und Informatik der Universität Münster
Einsteinstrasse 62
48149 Münster
E-Mail christian.engwer at uni-muenster.de
Telefon +49 251 83-35067
FAX +49 251 83-32729
More information about the Dune-devel
mailing list