[dune-fem] Broken build of project due to DUNE_VERSION_DEPRECATED

[Agnese, Marco]

Hi!

I am trying to compile a project using the last version of the trunk but it fails. It compiled yesterday. 
I don't see anything suspicious in the last two commits of Tobias but for some reason I receive the following errors:

In file included from /usr/local_machine/dune-trunk/dune-fem/dune/fem/space/basisfunctionset/default.hh:20:0,
                 from /usr/local_machine/dune-trunk/dune-fem/dune/fem/space/lagrange/space.hh:16,
                 from /usr/local_machine/dune-trunk/dune-fem/dune/fem/space/lagrange.hh:1,
                 from vertexfunction.hh:16,
                 from coupledmeshmanager.hh:21,
                 from dune_navier_stokes_splitted.cc:27:
/usr/local_machine/dune-trunk/dune-fem/dune/fem/space/common/discretefunctionspace.hh: At global scope:
/usr/local_machine/dune-trunk/dune-fem/dune/fem/space/common/discretefunctionspace.hh:690:35: error: ‘remove’ is not a type
       DUNE_VERSION_DEPRECATED(3,0,remove)
                                   ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:44: note: in definition of macro ‘DUNE_VERSION_DEPRECATED’
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                            ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:53: error: ISO C++ forbids declaration of ‘DUNE_VERSION_DEPRECATED_3_0’ with no type [-fpermissive]
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                                     ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/space/common/discretefunctionspace.hh:690:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:53: error: expected ‘;’ at end of member declaration
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                                     ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/space/common/discretefunctionspace.hh:690:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
In file included from /usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:23:0,
                 from /usr/local_machine/dune-trunk/dune-fem/dune/fem/function/blockvectorfunction/blockvectorfunction.hh:17,
                 from /usr/local_machine/dune-trunk/dune-fem/dune/fem/function/blockvectorfunction.hh:1,
                 from vertexfunction.hh:18,
                 from coupledmeshmanager.hh:21,
                 from dune_navier_stokes_splitted.cc:27:
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:310:35: error: ‘remove’ is not a type
       DUNE_VERSION_DEPRECATED(3,0,remove)
                                   ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:44: note: in definition of macro ‘DUNE_VERSION_DEPRECATED’
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                            ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:53: error: ISO C++ forbids declaration of ‘DUNE_VERSION_DEPRECATED_3_0’ with no type [-fpermissive]
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                                     ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:310:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:53: error: expected ‘;’ at end of member declaration
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                                     ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:310:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:331:35: error: ‘remove’ is not a type
       DUNE_VERSION_DEPRECATED(3,0,remove)
                                   ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:44: note: in definition of macro ‘DUNE_VERSION_DEPRECATED’
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                            ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:53: error: ISO C++ forbids declaration of ‘DUNE_VERSION_DEPRECATED_3_0’ with no type [-fpermissive]
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                                     ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:331:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:53: error: expected ‘;’ at end of member declaration
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                                     ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:331:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:2: error: ‘int Dune::Fem::DiscreteFunctionInterface<Impl>::DUNE_VERSION_DEPRECATED_3_0(int)’ cannot be overloaded
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
  ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:331:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:2: error: with ‘int Dune::Fem::DiscreteFunctionInterface<Impl>::DUNE_VERSION_DEPRECATED_3_0(int)’
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
  ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:310:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:351:35: error: ‘remove’ is not a type
       DUNE_VERSION_DEPRECATED(3,0,remove)
                                   ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:44: note: in definition of macro ‘DUNE_VERSION_DEPRECATED’
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                            ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:53: error: ISO C++ forbids declaration of ‘DUNE_VERSION_DEPRECATED_3_0’ with no type [-fpermissive]
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                                     ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:351:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:53: error: expected ‘;’ at end of member declaration
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
                                                     ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:351:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:2: error: ‘int Dune::Fem::DiscreteFunctionInterface<Impl>::DUNE_VERSION_DEPRECATED_3_0(int)’ cannot be overloaded
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
  ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:351:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/version.hh:20:2: error: with ‘int Dune::Fem::DiscreteFunctionInterface<Impl>::DUNE_VERSION_DEPRECATED_3_0(int)’
  DUNE_VERSION_DEPRECATED_##major##_##minor(newmethod)
  ^
/usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:310:7: note: in expansion of macro ‘DUNE_VERSION_DEPRECATED’
       DUNE_VERSION_DEPRECATED(3,0,remove)
       ^
In file included from /usr/local_machine/dune-trunk/dune-fem/dune/fem/function/common/discretefunction.hh:17:0,
                 from /usr/local_machine/dune-trunk/dune-fem/dune/fem/function/blockvectorfunction/blockvectorfunction.hh:17,
                 from /usr/local_machine/dune-trunk/dune-fem/dune/fem/function/blockvectorfunction.hh:1,
                 from vertexfunction.hh:18,
                 from coupledmeshmanager.hh:21,
                 from dune_navier_stokes_splitted.cc:27:
/usr/local_machine/dune-trunk/dune-fem/dune/fem/io/file/persistencemanager.hh:479:27: warning: ‘Dune::Fem::{anonymous}::persistenceManager’ defined but not used [-Wunused-variable]
       PersistenceManager &persistenceManager = PersistenceManager::instance();
                           ^
make[3]: *** [dune_navier_stokes_splitted-dune_navier_stokes_splitted.o] Error 1
make[3]: Leaving directory `/home/clustor/ma/m/ma2413/dune-repo/dune-navier-stokes-splitted/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/clustor/ma/m/ma2413/dune-repo/dune-navier-stokes-splitted/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/clustor/ma/m/ma2413/dune-repo/dune-navier-stokes-splitted'
make: *** [all] Error 2


Without the last two commits, instead, I obtain an error at linking stage:

mv -f .deps/dune_navier_stokes_splitted-dune_navier_stokes_splitted.Tpo .deps/dune_navier_stokes_splitted-dune_navier_stokes_splitted.Po
/bin/bash ../libtool  --tag=CXX   --mode=link g++ -std=c++11  -O3 -Wall -funroll-loops -finline-functions -fomit-frame-pointer -ffast-math -mfpmath=sse -msse3 -Wl,-no-as-needed -pthread                 -Wl,-no-as-needed -pthread             -lumfpack -lspqr -lsuitesparseconfig -lcholmod -lamd -lcolamd -lccolamd -lcamd -lrt -lblas -lgfortran -lGmsh  -o dune_navier_stokes_splitted dune_navier_stokes_splitted-dune_navier_stokes_splitted.o -Wl,-no-as-needed -pthread               /usr/local_machine/dune-trunk/dune-fem/lib/libdunefem.la /usr/local_machine/dune-trunk/dune-grid/lib/libdunegrid.la /usr/local_machine/dune-trunk/dune-geometry/lib/libdunegeometry.la /usr/local_machine/dune-trunk/dune-common/lib/libdunecommon.la     -L/usr/local_machine/dune-trunk/dune-grid/lib -ldunealbertagrid_2d -ldunegrid -L/usr/local_machine/alberta-3.0.0/lib -lalberta_2d -L/usr/local_machine/alberta-3.0.0/lib -lalberta_utilities    -pthread -Wl,-rpath -Wl,/usr/local_machine/openmpi-1.8.4/lib -Wl,--enable-new-dtags -L/usr/local_machine/openmpi-1.8.4/lib -lmpi  -L/usr/local_machine/suitesparse-4.4.0/lib -L/usr/local_machine/suitesparse-4.4.0/lib -L/usr/local_machine/suitesparse-4.4.0/lib -L/usr/local_machine/gmsh-2.9.3/lib   /usr/local_machine/dune-trunk/dune-fem/lib/libdunefem.la /usr/local_machine/dune-trunk/dune-grid/lib/libdunegrid.la /usr/local_machine/dune-trunk/dune-geometry/lib/libdunegeometry.la /usr/local_machine/dune-trunk/dune-common/lib/libdunecommon.la 
libtool: link: g++ -std=c++11 -O3 -Wall -funroll-loops -finline-functions -fomit-frame-pointer -ffast-math -mfpmath=sse -msse3 -Wl,-no-as-needed -pthread -Wl,-no-as-needed -pthread -o dune_navier_stokes_splitted dune_navier_stokes_splitted-dune_navier_stokes_splitted.o -Wl,-no-as-needed -pthread -pthread -Wl,-rpath -Wl,/usr/local_machine/openmpi-1.8.4/lib -Wl,--enable-new-dtags  -lumfpack -lspqr -lsuitesparseconfig -lcholmod -lamd -lcolamd -lccolamd -lcamd -lGmsh -L/usr/local_machine/dune-trunk/dune-grid/lib /usr/local_machine/dune-trunk/dune-grid/lib/.libs/libdunealbertagrid_2d.a -L/usr/local_machine/alberta-3.0.0/lib -L/usr/local_machine/ug-3.11.0/lib -L/usr/local_machine/openmpi-1.8.4/lib /usr/local_machine/alberta-3.0.0/lib/libalberta_2d.so /usr/local_machine/alberta-3.0.0/lib/libalberta_utilities.so -L/usr/local_machine/suitesparse-4.4.0/lib -L/usr/local_machine/gmsh-2.9.3/lib /usr/local_machine/dune-trunk/dune-fem/lib/.libs/libdunefem.a -lm /usr/local_machine/dune-trunk/dune-grid/lib/.libs/libdunegrid.a /usr/local_machine/ug-3.11.0/lib/libugS2.a /usr/local_machine/ug-3.11.0/lib/libugS3.a /usr/local_machine/ug-3.11.0/lib/libdevS.a /usr/local_machine/openmpi-1.8.4/lib/libmpi.so /usr/local_machine/openmpi-1.8.4/lib/libopen-rte.so /usr/local_machine/openmpi-1.8.4/lib/libopen-pal.so -ldl -lrt -lutil /usr/local_machine/dune-trunk/dune-geometry/lib/.libs/libdunegeometry.a /usr/local_machine/dune-trunk/dune-common/lib/.libs/libdunecommon.a -llapack -lblas -lgfortran -lquadmath -pthread -Wl,-rpath -Wl,/usr/local_machine/alberta-3.0.0/lib -Wl,-rpath -Wl,/usr/local_machine/openmpi-1.8.4/lib -Wl,-rpath -Wl,/usr/local_machine/alberta-3.0.0/lib -Wl,-rpath -Wl,/usr/local_machine/openmpi-1.8.4/lib
/usr/bin/ld: /usr/local_machine/suitesparse-4.4.0/lib/libcholmod.a(cholmod_metis.o): undefined reference to symbol 'METIS_ComputeVertexSeparator'
/usr/local_machine/petsc-3.5.3/lib/libpetsc.so.3.5: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[3]: *** [dune_navier_stokes_splitted] Error 1
make[3]: Leaving directory `/home/clustor/ma/m/ma2413/dune-repo/dune-navier-stokes-splitted/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/clustor/ma/m/ma2413/dune-repo/dune-navier-stokes-splitted/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/clustor/ma/m/ma2413/dune-repo/dune-navier-stokes-splitted'
make: *** [all] Error 2

What is the issue? 

Thank you very much for your hep,
Cheers,
Marco.