[Dune] [#959] Separate grid and geometry parts from (Basic-/Generic-)Geometry

Dune flyspray at dune-project.org
Sat Nov 12 21:21:57 CET 2011


THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#959 - Separate grid and geometry parts from (Basic-/Generic-)Geometry
User who did this - Martin Nolte (nolte)

----------
I am absolutely in favor of moving GenericGeometry::Geometry (possibly renaming it to GlobalGeometry) and GenericGeometry::LocalGeometry back to dune-grid. However, I dislike renaming the class Dune::Geometry for several reasons. It is, for example, a key interface structure in dune-grid and might be used in several places. Secondly, it correctly names the object: It is a geometry.

On the other hand, I understand that the geometry conceptually belongs into the module dune-geometry. I would even suggest to move it there in the long run. Right now, this is impossible due to the unfortunate choice of fixed template arguments. But that is another ongoing discussion.

Finally, a word of warning: The BasicGeometry solely exists to unify the implementation of GenericGeometry::Geometry and GenericGeometry::LocalGeometry. It was never intended to be anything else and any change should be done keeping this in mind. Actually, in my ideal dune-grid, the classes GenericGeometry::Geometry and GenericGeometry::LocalGeometry would not be necessary at all, because the template argument list of Dune::Geometry would be less restrictive.
----------

More information can be found at the following URL:
http://www.dune-project.org/flyspray/index.php?do=details&task_id=959#comment2876

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.




More information about the Dune mailing list