[Dune] Removal of deprecated VTKOptions

Martin Nolte nolte at mathematik.uni-freiburg.de
Thu Jun 14 16:26:13 CEST 2012


Ooops, I meant "announced implicitly" in the first paragraph and "announced 
explicitly" in the second one. Sorry for the confusion.

On 06/14/2012 04:19 PM, Martin Nolte wrote:
> Hi Christian, hi Markus,
>
> while I do see your point, I am forced to agree with Christoph. The removal
> was announced and I am very happy that someone finds the time to remove this
> stuff before we add new deprecations. If you want to stick to your old code,
> use the release.
>
> Of course, announcing such changes does allow people to react more
> appropriately and should therefore be done. But, let's be honest: Who has ever
> reacted before the commit?
>
> Moreover, we have a revision control system, so we can always revert the
> changes. I must admit, though, that I would be very interested in the
> reactions to reverting the removal of a depreceted feature ;-).
>
> In any case, we should really discuss communication (between developers) in
> Münster. This seems to be a very crucial point for future development.
>
> Best,
>
> Martin
>
> On 06/14/2012 04:05 PM, Christian Engwer wrote:
>> Hi Markus,
>>
>> I do agree with you. Bigger changes should be announced and have been
>> announced in the past.
>>
>> On the other hand, it seems that these things weren't discussed with
>> Christoph. I don't care about the reasons, I just want to encourage
>> Christoph and (his mentor) Robert to coordinate such changes better.
>>
>> Christian
>>
>> On Thu, Jun 14, 2012 at 02:46:35PM +0200, Markus Blatt wrote:
>>> Dear fellow developers and contributors,
>>>
>>> it seems like unimportant DUNE developments are currently carried out
>>> at high speed. Some of us simply remove deprecated features without
>>> further prior notice rendering dependent modules unusable. Previously
>>> there were at least notifcations about such changes in the nature of
>>> "I will remove this in a week unless there are complaints". I would
>>> appreciate going back to such a policy ASAP.
>>>
>>> A good example is the removal of VTKOptions. Even with Christoph's
>>> patch it breaks most module depending on dune-grid
>>> (e.g. dune-pdelab-howto).
>>>
>>> Fixing it needs some more changes than expected:
>>>
>>> for i in `find . -name \*.[ch][ch] | xargs grep VTKOption | cut \
>>> --delimiter=":" -f 1`; do
>>> sed "s/VTKOptions/Options/g" $i> tmp&& mv tmp $i
>>> done
>>>
>>> for i in `find . -name \*.[ch][ch] | xargs grep binaryappended | cut \
>>> --delimiter=":" -f 1`; do
>>> sed "s/VTK::binaryappended/VTK::appendedraw/g" $i> tmp&& mv tmp $i
>>> done
>>>
>>> BTW: Why VTK::appendedraw and not VTK::appendeddraw ?
>>>
>>> Cheers,
>>>
>>> Markus
>>> --
>>> Do you need more support with DUNE or HPC in general?
>>>
>>> Dr. Markus Blatt - HPC-Simulation-Software& Services http://www.dr-blatt.de
>>> Hans-Bunte-Str. 8-10, 69123 Heidelberg, Germany
>>> Tel.: +49 (0) 160 97590858 Fax: +49 (0)322 1108991658
>>>
>>> _______________________________________________
>>> Dune mailing list
>>> Dune at dune-project.org
>>> http://lists.dune-project.org/mailman/listinfo/dune
>>>
>>
>

-- 
Dr. Martin Nolte <nolte at mathematik.uni-freiburg.de>

Universität Freiburg                                   phone: +49-761-203-5630
Abteilung für angewandte Mathematik                    fax:   +49-761-203-5632
Hermann-Herder-Straße 10
79104 Freiburg, Germany



More information about the Dune mailing list